Skip to content

Automatically convert TDS to relation protocol in hosted datacube #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

travisstebbins
Copy link
Contributor

@travisstebbins travisstebbins commented Feb 24, 2025

Summary

To improve user experience, this PR implements the following flow:

  1. The user is in hosted datacube and attempts to open a query that uses the old TDS protocol.
  2. If we detect that the query uses the old protocol (by checking if the return type of the query is a TDS), we use a new endpoint that can convert a lambda from the old TDS protocol to the new relation protocol.
  3. We then open the datacube with the transformed protocol.

This will prevent the current state, where if a user attempts to open a query in the old protocol using hosted datacube, it will fail to open.

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

linux-foundation-easycla bot commented Feb 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 682b679

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-application-data-cube Patch
@finos/legend-graph Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-catalog Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-catalog-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-catalog-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@travisstebbins travisstebbins force-pushed the convert-protocol-datacube branch 2 times, most recently from 31b035d to a294a0a Compare March 4, 2025 18:41
@travisstebbins travisstebbins marked this pull request as ready for review March 4, 2025 18:58
@travisstebbins travisstebbins requested a review from a team as a code owner March 4, 2025 18:58
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 61.37931% with 56 lines in your changes missing coverage. Please review.

Project coverage is 46.87%. Comparing base (807bf1f) to head (682b679).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../graph-manager/__test-utils__/EngineTestSupport.ts 0.00% 35 Missing ⚠️
...r/protocol/pure/v1/engine/V1_EngineServerClient.ts 38.88% 11 Missing ⚠️
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 88.37% 5 Missing ⚠️
...engine/pureProtocol/V1_LambdaTdsToRelationInput.ts 86.95% 3 Missing ⚠️
packages/legend-graph/src/index.ts 0.00% 1 Missing ⚠️
packages/legend-query-builder/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3906      +/-   ##
==========================================
+ Coverage   46.85%   46.87%   +0.01%     
==========================================
  Files        2294     2295       +1     
  Lines      402442   402587     +145     
  Branches    17500    16764     -736     
==========================================
+ Hits       188581   188706     +125     
+ Misses     213215   213128      -87     
- Partials      646      753     +107     
Files with missing lines Coverage Δ
...ts/__test-utils__/LegendDataCubeStoreTestUtils.tsx 100.00% <100.00%> (ø)
packages/legend-graph/src/index.ts 0.00% <0.00%> (ø)
packages/legend-query-builder/src/index.ts 0.00% <0.00%> (ø)
...engine/pureProtocol/V1_LambdaTdsToRelationInput.ts 86.95% <86.95%> (ø)
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 41.82% <88.37%> (+1.76%) ⬆️
...r/protocol/pure/v1/engine/V1_EngineServerClient.ts 46.53% <38.88%> (-0.12%) ⬇️
.../graph-manager/__test-utils__/EngineTestSupport.ts 0.00% <0.00%> (ø)

... and 391 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@travisstebbins travisstebbins force-pushed the convert-protocol-datacube branch from 8635ee0 to e84d4e2 Compare March 11, 2025 16:52
@travisstebbins travisstebbins force-pushed the convert-protocol-datacube branch from e84d4e2 to 0e4b6a4 Compare March 24, 2025 20:48
@travisstebbins travisstebbins force-pushed the convert-protocol-datacube branch from 3a76f5b to 224d9ad Compare March 26, 2025 13:44
@MauricioUyaguari MauricioUyaguari merged commit 507fdaa into finos:master Mar 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants