Snapshot building for filter operations (part of roundtrip) #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e17a1b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akphi
requested changes
Dec 16, 2024
...s/legend-data-cube/src/stores/core/__tests__/DataCubeQueryFilterSnapshotBuilder-repl.test.ts
Outdated
Show resolved
Hide resolved
...s/legend-data-cube/src/stores/core/__tests__/DataCubeQueryFilterSnapshotBuilder-repl.test.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/filter/DataCubeQueryFilterOperation.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/filter/DataCubeQueryFilterOperation.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/DataCubeQueryEngine.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/DataCubeQuerySnapshotBuilderUtils.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/DataCubeQuerySnapshotBuilderUtils.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/DataCubeQuerySnapshotBuilder.ts
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/DataCubeQuerySnapshotBuilderUtils.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/DataCubeQuerySnapshotBuilderUtils.ts
Outdated
Show resolved
Hide resolved
akphi
reviewed
Dec 16, 2024
...s/legend-data-cube/src/stores/core/__tests__/DataCubeQueryFilterSnapshotBuilder-repl.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3737 +/- ##
==========================================
+ Coverage 44.88% 46.15% +1.27%
==========================================
Files 2229 2229
Lines 385911 386183 +272
Branches 15874 16473 +599
==========================================
+ Hits 173204 178262 +5058
+ Misses 211943 207480 -4463
+ Partials 764 441 -323
|
akphi
reviewed
Dec 23, 2024
packages/legend-data-cube/src/stores/core/__tests__/DataCubeQuerySnapshotBuilder.repl-test.ts
Outdated
Show resolved
Hide resolved
packages/legend-data-cube/src/stores/core/__tests__/DataCubeQuerySnapshotBuilder.repl-test.ts
Outdated
Show resolved
Hide resolved
...s/legend-data-cube/src/stores/core/__tests__/DataCubeQueryFilterSnapshotBuilder.repl-test.ts
Outdated
Show resolved
Hide resolved
...s/legend-data-cube/src/stores/core/__tests__/DataCubeQueryFilterSnapshotBuilder.repl-test.ts
Outdated
Show resolved
Hide resolved
gs-gunjan
force-pushed
the
snapshot_filter
branch
from
efc0e74 to
5887c4e
Compare
akphi
reviewed
Dec 24, 2024
| @@ -234,6 +234,21 @@ export enum DataCubeQueryFilterOperator { | |||
| // TODO?: having, having in aggregate, between | |||
| } | |||
|
|
|||
| export enum DataCubeEngineFilterOperator { | |||
| return undefined; | ||
| } | ||
|
|
||
| function _buildFilterConditionSnapshot( |
There was a problem hiding this comment.
as discussed, distribute this logic to each of the operator. For common logic that can be shared, we can leave them here, e.g. _not(), etc.
There was a problem hiding this comment.
so this is the code for conditionExpression:
const filterCondition = filter;
const operation = filterOperations.find(
(op) => op.operator === filterCondition.operator,
);
const condition = operation?.buildConditionExpression(filterCondition);
operator for most cases is the same but different for some cases so will need switch case still to put in the operator but I get the comment
| throw new Error('Method not implemented.'); | ||
| } | ||
|
|
||
| static filterOperations = [ |
There was a problem hiding this comment.
let's remove this. This inherits the list from DataCubeEngine.
| [ | ||
| _filter( | ||
| snapshot.data.filter!, | ||
| Test__DataCubeEngine.filterOperations, |
There was a problem hiding this comment.
Suggested change
| Test__DataCubeEngine.filterOperations, | |
| const engine = new Test__DataCubeEngine(); | |
| ... | |
| engine.filterOperations, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?