Default value fixes in M3 compiler and reactivator

[aziemchawdhary-gs]

1. Fixes a bug in the compiled mode version of reactivator where evaluation of calls to new does not set default values defined on the class being instantiated. More specifically this bug occurs when the reactivator doesn't need to regenerate and compile Java code and can evaluate the call to new directly.

2. Fails compilation on association properties with default values. This was not supported in compiled mode and a new compiler check is added to not allow default values on association properties

[github-actions]

Test Results

   378 files     378 suites   1h 19m 50s ⏱️
3 567 tests 3 544 ✔️ 23 💤 0 ❌
5 139 runs  5 116 ✔️ 23 💤 0 ❌

Results for commit b1a40ae.

♻️ This comment has been updated with latest results.

[kevin-m-knight-gs]

Suggested change

	MutableList<String> userAssignedParameters = Lists.mutable.empty();
	MutableSet<String> userAssignedParameters = Sets.mutable.empty();

[kevin-m-knight-gs]

We have methods now on AbstractCompiledCoreInstance for dealing with default values. Maybe result above can be cast directly to AbstractCompiledCoreInstance? In case it needs to be cast to Any above, I'm casting it in the suggestion below.

Suggested change

	RichIterable<CoreInstance> classProperties = _Class.getSimpleProperties(aClass, ((CompiledExecutionSupport) es).getProcessorSupport());
	classProperties.forEach(new CheckedProcedure<CoreInstance>()
	{
	@Override
	public void safeValue(CoreInstance p) throws Exception
	{
	if (!userAssignedParameters.contains(p.getName()))
	{
	Property<?, ?> prop = (Property<?, ?>) p;
	DefaultValue defaultValue = prop._defaultValue();
	if (defaultValue != null)
	{
	Object res = reactivate(defaultValue._functionDefinition()._expressionSequence().getFirst(), new PureMap(Maps.fixedSize.empty()), bridge, es);
	Method method = c.getMethod("_" + prop._name(), RichIterable.class);
	if (res instanceof RichIterable)
	{
	method.invoke(result, res);
	}
	else
	{
	method.invoke(result, Lists.fixedSize.of(res));
	}
	}
	}
	AbstractCompiledCoreInstance instance = (AbstractCompiledCoreInstance) result;
	instance.getDefaultValueKeys().forEach(new CheckedProcedure<String>()
	{
	@Override
	public void safeValue(String p) throws Exception
	{
	if (!userAssignedParameters.contains(p))
	{
	RichIterable<?> defaultValues = instance.getDefaultValue(p, es);
	if ((defaultValues != null) && defaultValues.notEmpty())
	{
	Method method = c.getMethod("_" + prop._name(), RichIterable.class);
	method.invoke(result, defaultValues);
	}
	}