Adding compiler warnings for empty test asserts in alloy service #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Compiler Warnings for empty test asserts
rafaelbey
reviewed
Dec 2, 2024
| @@ -221,6 +221,11 @@ public static Root_meta_legend_service_metamodel_Test processServiceTest(Service | |||
| throw new EngineException("Test does not match execution type", serviceTest.sourceInformation, EngineErrorType.COMPILATION); | |||
| } | |||
| SingleExecutionTest singleExecutionTest = (SingleExecutionTest) serviceTest; | |||
|
|
|||
| if (singleExecutionTest.asserts != null && singleExecutionTest.asserts.isEmpty()) | |||
There was a problem hiding this comment.
Should not this be an or... is null or is empty? Same on the multi-execution check.
There was a problem hiding this comment.
I will make the above change and create the merge request again. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do / why is it needed ?
Adding compiler warnings for empty test asserts in alloy service