-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update relational database controls from markdown to yaml #540
base: main
Are you sure you want to change the base?
Conversation
@dogle-scottlogic - thanks for picking this one up. Comparing this to the common controls for object storage, I think the common controls list may well be the same for RDMS:
That would then leave the following RDMS specific controls as:
@eddie-knight @damienjburks @vrabotka @ianwalkersmithciticom - I reckon RBAC control should be converted to a common control? Also:
Is this unique to RDMS? Seems more...common...? Also:
Don't quite understand this one? Also,
Is now covered by the common controls and can be removed. @eddie-knight - I know RDMS started in the early stages of the project - were there any threats/controls specific to RDMS that we may have dropped along the way? |
@mlysaght2017 converting RBAC to a common control makes sense to me. |
da00cdc
to
60c883b
Compare
@dogle-scottlogic @ianwalkersmithciticom - it looks like you're both working on this via separate PRs - see #573 @dogle-scottlogic - if you're ok with this, I'm happy to merge this PR in its current state and then have @ianwalkersmithciticom work on additions/mappings/fixes as part of #554 |
@mlysaght2017 that's fine with me 👍 |
@dogle-scottlogic @damienjburks - do we know what the issue with the yaml checker is on this one? |
@mlysaght2017 - The branch needs a rebase to bring it up to date which might be the issue - I'll try and sort out today |
60c883b
to
fe58661
Compare
fe58661
to
ca52b72
Compare
rebased - just need to check if we want to keep in C02 and C03 or remove them for now |
@dogle-scottlogic seems like we should include those so as to not lose any progress |
@dogle-scottlogic - just that linting check to pass and then we should be good - thanks |
Co-authored-by: Eddie Knight <[email protected]>
Co-authored-by: Eddie Knight <[email protected]>
Co-authored-by: Eddie Knight <[email protected]>
Migrate the relational database controls file from
.md
to.yaml
.This addresses open issue #494
As far as I can tell this is the only file requiring migration to markdown.
TODO (@sshiells-scottlogic):
tlp_levels
for test requirements.threats
as the codes provided don't match our current patterns