Skip to content

Commit

Permalink
Merge pull request #293 from finos/main-6.1
Browse files Browse the repository at this point in the history
New release
  • Loading branch information
alex-karpovich authored Aug 8, 2024
2 parents 84d6738 + 075563d commit c1ab159
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 15 deletions.
14 changes: 13 additions & 1 deletion CVE.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,16 @@ Fix going to be integrated into Timebase codebase.
The SSI printenv command echoes user provided data without escaping and is, therefore, vulnerable to XSS.
SSI is disabled by default. The printenv command is intended for debugging and is unlikely to be present in a production website.
```
TimeBase Server with embedded tomcat setup is not affected, because SSI is disabled.
TimeBase Server with embedded tomcat setup is not affected, because SSI is disabled.


12. [CVE-2016-1000027](https://www.cvedetails.com/cve/CVE-2016-1000027)
```
Pivotal Spring Framework through 5.3.16 suffers from a potential remote code execution (RCE) issue if used for Java deserialization of untrusted data.
Depending on how the library is implemented within a product, this issue may or not occur, and authentication may be required.
NOTE: the vendor's position is that untrusted data is not an intended use case. The product's behavior will not be changed because some users rely on deserialization of trusted data.
```

TimeBase Server with embedded tomcat setup is not affected, because we do not use object serialization via RMI. TimeBase uses own binary communication protocol to serialize internal objects.
Overall recommentation - do not open TimeBase HTTP endpoints to public internet.
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,10 @@
*
*/
public class DBQueryRunner {
private final SelectionOptions opts = new SelectionOptions ();
private final Map <String, Parameter> params =
new TreeMap <String, Parameter> ();

public DBQueryRunner() {
opts.raw = true;
opts.channelQOS = ChannelQualityOfService.MIN_INIT_TIME;
}

public void clearParams () {
Expand Down Expand Up @@ -118,6 +115,9 @@ public void runQuery (
) throws IOException
{
try {
SelectionOptions opts = new SelectionOptions();
opts.raw = true;
opts.channelQOS = ChannelQualityOfService.MIN_INIT_TIME;
InstrumentMessageSource ims = db.executeQuery(query, opts, null, null, startTimestamp, endTimestamp, getParams());
IMSPrinter imsp = printJson ? new JsonIMSPrinter(out) : new SimpleIMSPrinter(out);
imsp.setMaxCount (numResults);
Expand All @@ -129,4 +129,4 @@ public void runQuery (
out.flush ();
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -59,25 +59,20 @@ public InstrumentMessageSource executeQuery (
{
if (options == null)
options = new SelectionOptions ();

switch (mode) {
case NORMAL:
options.live = false;
options.reversed = false;
options.realTimeNotification = false;
break;

case REVERSE:
options.live = false;
options.reversed = true;
options.realTimeNotification = false;
break;

case LIVE:
options.live = true;
options.realTimeNotification = false;
break;

case HYBRID:
options.live = true;
options.realTimeNotification = true;
Expand All @@ -97,4 +92,4 @@ public ClassSet<RecordClassDescriptor> getSchema() {

public void close () {
}
}
}

0 comments on commit c1ab159

Please sign in to comment.