Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : tab reloading when changed #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ashishrawat2911
Copy link

No description provided.

@filiph
Copy link
Owner

filiph commented Aug 21, 2019

Thanks for the contribution!

I'd love to merge this, but could you please filter out the extra changes? I see some additional print statements and changes to things like local.properties, plus a bunch of changes to whitespace. Your git client should be able to let you select the exact chunk of code that you're contributing.

Thanks again, and sorry for the delay. Somehow the github notification didn't reach my inbox.

@ashishrawat2911
Copy link
Author

Yes, I have resolved all the conflicts.

@filiph
Copy link
Owner

filiph commented Aug 22, 2019

Sorry for being difficult, but I still see whitespace changes in 4 files: https://github.com/filiph/hn_app/pull/9/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants