-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added an option to disable the "Open in Windows Terminal" action #17250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
@@ -10,6 +10,8 @@ internal partial class OpenTerminalAction : ObservableObject, IAction | |||
{ | |||
private readonly IContentPageContext context; | |||
|
|||
private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use field for DI instances
@@ -10,6 +10,8 @@ internal partial class OpenTerminalAction : ObservableObject, IAction | |||
{ | |||
private readonly IContentPageContext context; | |||
|
|||
private IUserSettingsService UserSettingsService { get; } = Ioc.Default.GetRequiredService<IUserSettingsService>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action should still be available when the menu item is turned off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean by that.
The action should be executable when the setting to turn it off is turned off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, this setting is only for the context menu item, it's not meant to disable the action.
@@ -261,6 +261,11 @@ | |||
<ToggleSwitch AutomationProperties.Name="{helpers:ResourceString Name=ShowOpenInNewPane}" IsOn="{x:Bind ViewModel.ShowOpenInNewPane, Mode=TwoWay}" /> | |||
</wctcontrols:SettingsCard> | |||
|
|||
<!-- Open in Windows Terminal --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setting should probably match the order of the context menu item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? The setting is shown after all the "Open folder in xyz" settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setting should be right before the setting for 'Edit tags', this way it's consistent with the order of the Context Menu items.
42c8207
to
4c7493f
Compare
Resolved / Related Issues
Steps used to test these changes