This repository was archived by the owner on Aug 23, 2021. It is now read-only.
feat: add dht.findPeer command #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
suggested changes
Apr 5, 2019
src/cmd/dht/find-peer.js
Outdated
| multiaddrs.push(Multiaddr(addr)) | ||
| } | ||
|
|
||
| return multiaddrs |
There was a problem hiding this comment.
It could take a long time to collect all of these addresses - we should return an iterator here so that we can stream addresses to the caller as they're discovered.
nijynot
force-pushed
the
feat/dht-findpeer
branch
from
6b76f96 to
c21508a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47 and fixes some lint errors that I got from the levels tests.