Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Extract Curio sources #12042

Merged
merged 9 commits into from
May 28, 2024
Merged

misc: Extract Curio sources #12042

merged 9 commits into from
May 28, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 24, 2024

Related Issues

Proposed Changes

This work extracts curio sources to https://github.com/filecoin-project/curio. The last few commits remove the code from the lotus repo.

Additional Info

I do highly recommend merging this with a rebase, not a squash so that the initial refactor moves remain visible here (there are also matching commits in the curio repo, but imo much better to have that history recorded in lotus as well)

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link

github-actions bot commented May 24, 2024

All checks have completed

❌ Failed Check / Check (lint-all) (pull_request)

@magik6k magik6k changed the title wip: curio extract misc: Extract Curio sources May 27, 2024
@magik6k magik6k requested review from snadrus and LexLuthr May 27, 2024 17:45
@magik6k
Copy link
Contributor Author

magik6k commented May 27, 2024

(Lint errors are from master)

@LexLuthr
Copy link
Contributor

@magik6k Can you please also remove #12051?

@magik6k magik6k marked this pull request as ready for review May 28, 2024 08:57
@magik6k
Copy link
Contributor Author

magik6k commented May 28, 2024

The only remaining reference to curio is now the schema name in harmonydb (which has to be kept in this repo for compatible DBIndex)

lotus$ ag curio
lib/harmony/harmonydb/harmonydb.go
87:     schema := "curio"

@magik6k magik6k merged commit 110da93 into master May 28, 2024
93 of 94 checks passed
@magik6k magik6k deleted the feat/curio-extract branch May 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants