-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: curio forest compat #12038
feat: curio forest compat #12038
Conversation
Along with the given list, Curio also needed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a usage in chain-connectivity.mjs
as well to track chain sync. We might need to modify that to work individually with node types. We can probably handle that in the same PR where we add the Forest integration.
@@ -147,7 +148,7 @@ func StorageNetworkName(ctx helpers.MetricsCtx, a v1api.FullNode) (dtypes.Networ | |||
return a.StateNetworkName(ctx) | |||
} | |||
|
|||
func SealProofType(maddr dtypes.MinerAddress, fnapi v1api.FullNode) (abi.RegisteredSealProof, error) { | |||
func SealProofType(maddr dtypes.MinerAddress, fnapi daemonapi.Daemon) (abi.RegisteredSealProof, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's copy over this function to Curio deps to fix the failing tests. I think that's the cheapest solution here instead of a complicated FX dependency fix.
Closing as this has been ported. |
Related Issues
Limited the API set in Curio to this list.
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps