Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create filament-cookie-consent.md #412

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Create filament-cookie-consent.md #412

merged 4 commits into from
Jun 3, 2024

Conversation

marcogermani87
Copy link
Contributor

No description provided.

saade
saade requested changes May 14, 2024
View reviewed changes
Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Your plugin doesn't have an image, please add images as per our Contributing guide. It must fit the 16:9 aspect ratio, at least 2560x1440 pixels in size, and preferably a JPEG. They are mandatory. For plugins, you could use Beyond Code's banner generator to generate them.

Also, please add an author profile.

Please let us know when you've addressed these issues.

@marcogermani87
Copy link
Contributor Author

Hey! Your plugin doesn't have an image, please add images as per our Contributing guide. It must fit the 16:9 aspect ratio, at least 2560x1440 pixels in size, and preferably a JPEG. They are mandatory. For plugins, you could use Beyond Code's banner generator to generate them.

Also, please add an author profile.

Please let us know when you've addressed these issues.

Done, thanks.

marcogermani87

This comment was marked as duplicate.

Sign in to view

@marcogermani87 marcogermani87 requested a review from saade May 15, 2024 00:08
@marcogermani87
Copy link
Contributor Author

Hi @saade, news on PR merge?

@saade saade merged commit 84b0fca into filamentphp:main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saade saade saade approved these changes

Assignees
No one assigned
Labels
new author new plugin pending changes
Projects
Website content submissions
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcogermani87 @saade