Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guava Knowledge Base plugin #398

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

lukas-frey
Copy link
Contributor

No description provided.

Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! We couldn't embed the video in your README correctly. Please change it to a raw-HTML markup. It should look something like:

<video width="320" height="240" controls>
  <source src=“RAW-VIDEO-URL-HERE” type="video/mp4">
</video>


Please let us know when you've addressed these issues.

@lukas-frey
Copy link
Contributor Author

Hey! We couldn't embed the video in your README correctly. Please change it to a raw-HTML markup. It should look something like:

<video width="320" height="240" controls>
  <source src=“RAW-VIDEO-URL-HERE” type="video/mp4">
</video>


Please let us know when you've addressed these issues.

Done

@lukas-frey lukas-frey requested a review from saade May 15, 2024 06:23
@saade
Copy link
Member

saade commented May 21, 2024

Hey! The video is still broken, it looks like the quotes are wrong in your readme file.

image

@lukas-frey
Copy link
Contributor Author

fixed

@saade saade merged commit 4f63da0 into filamentphp:main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants