Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aherbert bug fixes #22

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

aherbert bug fixes #22

wants to merge 15 commits into from

Conversation

aherbert
Copy link

Bug fixes for the 3D viewer.

One bug could be demonstrated using a JUnit test so I have added dependencies to the POM to allow it to be run. The fix to the actual class is trivial and so the test could be removed as no other tests are present in the package.

Some changes are not bug fixes but extensions to the public API to expose more functionality in the Image3DUniverse and the view window.

aherbert added 15 commits June 11, 2018 17:26
This allows sub-classes of the CustomMesh to be exported
The methods previously ignored the default orientation of y-downwards.
Thus they could not be used to reset the view to match the default view
returned by reset view command.
This will reset to the same directory as that used for save since the
SaveDialog is called with the default name and the directory is left to
be the default directory.
Showing the pop-up on mouse press and release is redundant. Just do it
on mouse released.
This is used when the menubar has been updated.
The BoundingBox could throw an exception when the content added to an
image had identical min and max coordinates, e.g. a single point.

This has required updating the POM to bring in the JOGL runtime for the
test. This can be removed if the test is deemed trivial.
@ctrueden
Copy link
Member

ctrueden commented Jul 2, 2018

Thank you @aherbert, and sorry for the delay in reply. I will be out of the office for the next two weeks, and am still not caught up on post-travel tasks from last time, so unfortunately it may be awhile before I get to reviewing and merging this. But I will do so as soon as I can—it's in my queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants