[npm#5280] Allow --no-save to prevent other save flags from overwriti…

…ng save
ficocelliguy · Mar 5, 2024 · 7db7c47 · 7db7c47
1 parent f7e4d7d
commit 7db7c47
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/workspaces/config/lib/index.js b/workspaces/config/lib/index.js
@@ -235,7 +235,8 @@ class Config {
 
  // Only set 'save' to true if a saveType has been specified
  // and if 'save' is false due to non-default config
- if (!this.isDefault('save') && this.#flatOptions.saveType) {
+ if (!this.isDefault('save') && this.#flatOptions.saveType
+ && !this.argv?.includes('--no-save')) {
  this.#flatOptions.save = true
  }
  this.#flatOptions.nodeBin = this.execPath

diff --git a/workspaces/config/test/index.js b/workspaces/config/test/index.js
@@ -944,9 +944,9 @@ t.test('manages the save flag when flat is retrieved', t => {
  const c = await buildConfig(['--no-save'], true)
  t.equal(c.flat.save, false)
  })
- t.test('overwrites save if --no-save is present and also a save flag', async t => {
- const c = await buildConfig(['--save-prod', '--no-save'], false)
- t.equal(c.flat.save, true)
+ t.test('oes not overwrite save --no-save is present in addition to save flag', async t => {
+ const c = await buildConfig(['--save-prod', '--no-save'], true)
+ t.equal(c.flat.save, false)
  })
  t.end()
 })