Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANs2D rules #356

Merged
merged 13 commits into from
Jan 28, 2025
Merged

SANs2D rules #356

merged 13 commits into from
Jan 28, 2025

Conversation

Pasarus
Copy link
Member

@Pasarus Pasarus commented Jan 27, 2025

Closes https://github.com/fiaisis/planning/issues/29

Description

Creates the rules to facilitate creating SANs2D jobs on the cluster. Took the LOQ rules and made them generic followed by adding support for the actual SANs2D functionality.

Copy link
Collaborator

@keiranjprice101 keiranjprice101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense and look good. But the logging is very confusing to me.

rundetection/rules/sans_rules.py Outdated Show resolved Hide resolved
@Pasarus Pasarus merged commit 7998d70 into main Jan 28, 2025
2 checks passed
@Pasarus Pasarus deleted the sans2d_rules branch January 28, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants