Fix MARI rules tests

rundetection/rules/mari_rules.py

@@ -15,7 +15,7 @@
 
 class MariStitchRule(Rule[bool]):
     """
-    The MariStitchRule is the rule that applies
+    The MariStitchRule is the rule that applies, dependent on the other rules running first. This runs last.
     """
 
     def __init__(self, value: bool) -> None:

test/rules/test_mari_rules.py

@@ -2,10 +2,8 @@
 Test for mari rules
 """
 
-import json
 import os
 from pathlib import Path
-from typing import Any
 from unittest.mock import patch
 
 import pytest
@@ -14,18 +12,6 @@
 from rundetection.rules.mari_rules import MariMaskFileRule, MariStitchRule, MariWBVANRule
 
 
-def get_specification_value(key: str) -> Any:
-    """
-    Given a key, return the specification value
-    :param key: The key for the rule
-    :return: The rule value
-    """
-    path = Path("rundetection/specifications/mari_specification.json")
-    with path.open(encoding="utf-8") as fle:
-        spec = json.load(fle)
-        return spec[key]
-
-
 @pytest.fixture(autouse=True)
 def _working_directory_fix():
     # Set dir to repo root for purposes of the test.
@@ -110,14 +96,16 @@ def test_verify_multiple_runs(mari_stitch_rule_true, job_request):
     :param job_request: job request fixture
     :return: None
     """
+    rule = MariMaskFileRule("some link")
+    rule.verify(job_request)
+    rule = MariWBVANRule(1234567)
+    rule.verify(job_request)
     with patch("rundetection.rules.mari_rules.MariStitchRule._get_runs_to_stitch", return_value=[1, 2, 3]):
         mari_stitch_rule_true.verify(job_request)
 
     assert len(job_request.additional_requests) == 1
-    assert job_request.additional_requests[0].additional_values["mask_file_link"] == get_specification_value(
-        "marimaskfile"
-    )
-    assert job_request.additional_requests[0].additional_values["wbvan"] == get_specification_value("mariwbvan")
+    assert job_request.additional_requests[0].additional_values["mask_file_link"] == "some link"
+    assert job_request.additional_requests[0].additional_values["wbvan"] == 1234567
 
 
 def test_mari_mask_rule(job_request):