Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth bug #96

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fix auth bug #96

merged 4 commits into from
Jan 30, 2025

Conversation

Pasarus
Copy link
Member

@Pasarus Pasarus commented Jan 29, 2025

Closes None, issue was noticed in staging

Description

Display name didn't exist due to an issue with what we are calling (Called with post instead of get), and then it failed to return correctly, so some error handling has been added.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.38%. Comparing base (2027de2) to head (ae75e9a).

Files with missing lines Patch % Lines
fia_auth/auth.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   98.63%   94.38%   -4.25%     
==========================================
  Files          18       10       -8     
  Lines         585      392     -193     
==========================================
- Hits          577      370     -207     
- Misses          8       22      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pasarus Pasarus merged commit 407dbf7 into main Jan 30, 2025
@Pasarus Pasarus deleted the fix_display_name branch January 30, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants