Add find_file functionality from plotting service to api #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of refactoring, and preventing duplication of code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 86.92% 84.34% -2.59%
==========================================
Files 28 28
Lines 895 958 +63
==========================================
+ Hits 778 808 +30
- Misses 117 150 +33 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The cause of the test failing (due to misreading the type) is not clear, this is a test fix for the tests
Some functions were hastily moved over to FIA-API during find_files refactor but these were not needed, the related commit in plotting service fiaisis/plotting-service@0a5330d
Pasarus
requested changes
Jan 16, 2025
| level=logging.INFO, | ||
| ) | ||
| logger = logging.getLogger(__name__) | ||
| logger.info("Starting Plotting Service") |
There was a problem hiding this comment.
Lets import the already existent logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of refactoring, and preventing duplication of code
Closes #423 (in combination with related PR for the plotting_service repo)
Description
This PR will: