Strip Attachment elements from sidebar #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The count of elements is (or at least can be) different depending on the email headers - like reply-to, etc… So rather than relying on the count and stripping the last two, find the `<dt>` containing the "Attachments:" label text, and then remove it and the element following it.
stevenharman
force-pushed
the
strip_attachment_link_in_sidebar
branch
from
dd2ad0c
to
588f0c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count of elements is (or at least can be) different depending on the email headers - like reply-to, etc… So rather than relying on the count and stripping the last two, find the
<dt>containing the "Attachments:" label text, and then remove it and the element following it.Here's what it looks like with this patch applied. Note the Attachments aren't in the sidebar, but still show up in the iframe.