Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details for contribution workflow #865

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

RemDelaporteMathurin
Copy link
Collaborator

Proposed changes

This just adds a few steps to the contribution workflow.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Copy link
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is certainly an improvement from what was there previously. However, as much as I understand that technically you don't need a fenics environment to contribute, I still think we should mention this, and that one should run tests locally before asking for a review etc.

@RemDelaporteMathurin
Copy link
Collaborator Author

and that one should run tests locally before asking for a review etc.

Well in that case, you need an environment to contribute

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (31864c8) to head (80ff56d).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   99.55%   99.63%   +0.07%     
==========================================
  Files          61       61              
  Lines        2724     2990     +266     
==========================================
+ Hits         2712     2979     +267     
+ Misses         12       11       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemDelaporteMathurin RemDelaporteMathurin merged commit 1a49542 into main Aug 5, 2024
8 checks passed
@RemDelaporteMathurin RemDelaporteMathurin deleted the clone-contribution branch August 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants