Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers that starts with . should be allowed #234

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Numbers that starts with . should be allowed #234

merged 5 commits into from
Jul 18, 2023

Conversation

HarshMakwana27
Copy link
Contributor

@HarshMakwana27 HarshMakwana27 commented Jul 16, 2023 •
edited by ferraridamiano
Loading

Issue fixed by changes in onChanged and validator.

Fix #225

ferraridamiano
ferraridamiano requested changes Jul 17, 2023
View reviewed changes
Copy link
Owner

@ferraridamiano ferraridamiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just leaved few comments

android/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@ferraridamiano ferraridamiano changed the title Issue #225, solved ! Numbers that starts with . should be allowed Numbers that starts with . should be allowed Jul 17, 2023
@ferraridamiano ferraridamiano merged commit 106c2ea into ferraridamiano:master Jul 18, 2023
3 checks passed
@ferraridamiano
Copy link
Owner

ferraridamiano commented Jul 18, 2023 •
edited
Loading

Thank you @HarshMakwana27
There are a lot of issues like this that could be fixed if you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferraridamiano ferraridamiano ferraridamiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Numbers that starts with . should be allowed
2 participants
@HarshMakwana27 @ferraridamiano