Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change where the HttpRequestDenied is returned #37

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Aug 23, 2024

HttpRequestDenied errors are now returned async instead of immediately upon calling outgoing-handler/handle. I sort of think this is a worse behavior, and I do think we should figure out if it would be possible to keep the older behavior.

@rylev rylev requested a review from lann August 23, 2024 11:56
@lann
Copy link
Contributor

lann commented Aug 26, 2024

After more consideration I think this may actually be better behavior. It seems pretty reasonable that any validation process that could result in HttpRequestDenied could require some asynchronous processing for a variety of reasons, which makes it an opportunity to do other concurrent work.

Really I think this applies to most of the error-codes, which suggests either:

  • Assume that any error code can be returned from either handle or its future, equivalently
  • Assume that (almost) all error codes will be returned exclusively from the future, with the possible exception of things like HTTP-request-URI-too-long

@rylev rylev merged commit 6ec9e9d into main Aug 27, 2024
2 checks passed
@rylev rylev deleted the outbound-http-no-perms branch August 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants