Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new recipes not created correctly #95

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix: new recipes not created correctly #95

merged 2 commits into from
Jan 15, 2024

Conversation

SpecialAro
Copy link
Member

When you try to add a new recipe (previously) only name and recipeId were being taken into consideration. This fixes it.

@SpecialAro SpecialAro self-assigned this Jan 15, 2024
@SpecialAro SpecialAro requested a review from a team January 15, 2024 16:38
mcmxcdev
mcmxcdev approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@mcmxcdev mcmxcdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please set up your IDE to conform to adonis-js-check though, CI is currently failing.

@SpecialAro SpecialAro force-pushed the fix-issue-with-new-recipes branch from 06128c9 to 1544072 Compare January 15, 2024 16:45
@SpecialAro SpecialAro merged commit 3c965e7 into main Jan 15, 2024
1 check passed
@SpecialAro SpecialAro deleted the fix-issue-with-new-recipes branch January 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmxcdev mcmxcdev mcmxcdev approved these changes

Assignees

@SpecialAro SpecialAro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpecialAro @mcmxcdev