Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mason_logger): Progress logger spams terminal with messages longer than terminal columns #760

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(mason_logger): Progress logger spams terminal with messages longer than terminal columns #760

wants to merge 5 commits into from

Conversation

jtdLab
Copy link

@jtdLab jtdLab commented Feb 16, 2023

Status

READY

Description

Fixes: #711

Context: #713

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jtdLab jtdLab changed the title fix: Progress logger spams terminal with messages longer than terminal columns fix(mason_logger): Progress logger spams terminal with messages longer than terminal columns Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@felangel felangel Awaiting requested review from felangel felangel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: mason_logger progress logging with long string leads to weird behaviour
3 participants
@jtdLab @renancaraujo @felangel