Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

89 parametrize figure generation #92

Merged
merged 49 commits into from
Oct 17, 2024

Conversation

JavierCladellas
Copy link
Collaborator

Figure generation is now dynamic, and is specified by the plots field of the config json.
This plots config is uploaded inside the same item as the generated reframe report to girder.

example of plot configuration :

[
        {
            "title": "Plot title",
            "plot_types":[ "scatter","table"], // Supported types atm : "scatter", "table", "stacked_bar"
            "transformation":"performance", //Supported transformations: "performance", "relative_performance", "speedup"
            "variables": [
                "ElectricConstructor_createMesh",
                "ElectricConstructor_createExporters",
                "ElectricConstructor_graph"
            ],
            "names": [
                "createMesh",
                "createExporters",
                "graph"
            ],
            "xaxis": {
                "parameter": "nb_tasks",
                "label": "Number of tasks"
            },
            "secondary_axis": {
                "parameter": "hsize",
                "label": "Mesh size"
            },
            "yaxis": {
                "label": "execution time (s)"
            }
        }
]

@JavierCladellas JavierCladellas added the enhancement A new feature or request label Oct 9, 2024
@JavierCladellas JavierCladellas self-assigned this Oct 9, 2024
@JavierCladellas JavierCladellas linked an issue Oct 9, 2024 that may be closed by this pull request
3 tasks
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit 955c576
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/67066de13c30a3000878faf7
😎 Deploy Preview https://deploy-preview-92--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit f029fa2
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/67111add6f5fc7000875b674
😎 Deploy Preview https://deploy-preview-92--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas JavierCladellas marked this pull request as draft October 9, 2024 15:10
@JavierCladellas JavierCladellas marked this pull request as ready for review October 10, 2024 07:46
@JavierCladellas
Copy link
Collaborator Author

The code is now compatible with Python 3.8 for Netlify, the preview is up @prudhomm .
Some figures ( containing a slider axis) do not appear yet. This will be fixed with the release for feelpp/feelpp-asciidoctor-extensions#17

@prudhomm
Copy link
Member

it is great!!!

@prudhomm
Copy link
Member

I have to go to my course, let's discuss this afternoob

@JavierCladellas JavierCladellas merged commit d3c10dc into master Oct 17, 2024
16 checks passed
@JavierCladellas JavierCladellas deleted the 89-parametrize-figure-generation branch October 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametrize figure generation
2 participants