generated from feelpp/feelpp-project
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves: Add outputs and descriptions #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tputs-and-descriptions
✅ Deploy Preview for benchmarking-polite-crostata-92f389 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
prudhomm
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Insert benchmark description #74
Closes Add toolbox checkers #76
Added a table showing parameters and containing links to testcase descriptions
![Screenshot 2024-11-13 at 10 54 48](https://private-user-images.githubusercontent.com/82624449/385701626-3d4427f6-a1db-44e2-9eca-621d406f259b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMTk1MDQsIm5iZiI6MTczOTMxOTIwNCwicGF0aCI6Ii84MjYyNDQ0OS8zODU3MDE2MjYtM2Q0NDI3ZjYtYTFkYi00NGUyLTllY2EtNjIxZDQwNmYyNTliLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAwMTMyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE1ZGM4Y2RiODFlZDQxMTg5MDcxYmU5ZTI5ZGFlMTFkN2I2MGVmYzg5ZTQwOWQ1ODE0MzhiYTFhYTNhNTAzNTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bpNn9mN0uXlLGCEurvc6Ga0MhhLBChPxuf5J5GFvD6k)
Added general description of the use case ( must be exported by the application, or found somewhere )
Added possibility to export outputs as performance variables
Reference values and thresholds for outputs will be supported in Add reference values and thresholds #154
Main changes:
copyParametrizedDescriptions
method to feelpp/benchmarking/reframe/outputs.py OutputHandler class ( files are copied to the same directory as reports are exported right before the reframe's performance step ) And acopyDescription
method that copies a single case description, once, right after reframe's init step.AtomicReport
for parsing the parameters and finding the description files