Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves: Add outputs and descriptions #114

Merged
merged 33 commits into from
Nov 22, 2024
Merged

Conversation

JavierCladellas
Copy link
Collaborator

@JavierCladellas JavierCladellas commented Nov 13, 2024

Main changes:

  • Added a copyParametrizedDescriptions method to feelpp/benchmarking/reframe/outputs.py OutputHandler class ( files are copied to the same directory as reports are exported right before the reframe's performance step ) And a copyDescription method that copies a single case description, once, right after reframe's init step.
  • Changed item structure for generated reports (plots.json, reframe_report.json, parametrized_partials/*.adoc)
  • Added the table to the template, and some methods to AtomicReport for parsing the parameters and finding the description files
  • The syntax for specifying additional files is the following:
"additional_files":{
    "description_filepath":"path/to/file/my_case_description.adoc",
    "parameterized_descriptions_filepath":"{{output_directory}}/{{instance}}/{{use_case_name}}/my_parametrized_desc.adoc"
}

@JavierCladellas JavierCladellas added the enhancement A new feature or request label Nov 13, 2024
@JavierCladellas JavierCladellas self-assigned this Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit 575d3f0
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/673f51a9edc08900082db4d9
😎 Deploy Preview https://deploy-preview-114--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas JavierCladellas changed the title Add outputs and descriptions resolves: Add outputs and descriptions Nov 18, 2024
@JavierCladellas JavierCladellas marked this pull request as ready for review November 21, 2024 15:28
@prudhomm prudhomm merged commit baff467 into master Nov 22, 2024
16 checks passed
@prudhomm prudhomm deleted the add-outputs-and-descriptions branch November 22, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add toolbox checkers Insert benchmark description
2 participants