Fix race condition causing ProcessConsoleManager/LaunchManager sync failures

[Copilot]

testBug546710_ConsoleCreationRaceCondition randomly fails with "1 launch, 0 consoles" because ConsoleCreation jobs could run after their associated launch was removed, and removeLaunch() did not cancel pending jobs.

Changes

ProcessConsoleManager.java

• Early exit in ConsoleCreation.run(): Check isRegistered(launch) before creating the ProcessConsole. Previously the check only happened after addConsoles(), leaving a window where a job could create a console for a launch that was already gone.

  // New: bail out before allocating anything
  if (!launchManager.isRegistered(launch)) {
      return Status.CANCEL_STATUS;
  }
  // ... create console ...
  // Existing: still needed for the race during console creation
  if (!launchManager.isRegistered(launch)) {
      removeLaunch(launch);
  }

• Cancel pending jobs in removeLaunch(): When a launch is removed, explicitly cancel any queued ConsoleCreation jobs for its processes before attempting console removal. This closes the window where a waiting job starts running after the launch is already deregistered.

  for (Job job : Job.getJobManager().find(process)) {
      if (job instanceof ConsoleCreation) {
          job.cancel();
      }
  }

ProcessConsoleManagerTests.java

• Fix copy-paste typo: the assertion for "Second console not removed" was checking process1 instead of process2.

[fedejeanne]

@copilot How can you be sure this PR fixes the issue? Tell me how many times you ran the test with and without this fix. Did you even see the test failing before applying this fix?

[Copilot]

@copilot How can you be sure this PR fixes the issue? Tell me how many times you ran the test with and without this fix. Did you even see the test failing before applying this fix?

Honest answer: I did not run the test before or after applying the fix. The test requires a graphical display (it's a UI test that needs GTK/Xvnc) which isn't available in this sandbox environment - running it produces SWT.ERROR_NO_HANDLES and a process error code 13.

The fix is based on static code analysis of the race condition, not empirical test runs. The logic is:

Original race (why the test fails with "1 launch, 0 consoles"):

1. Job manager is suspended → two ConsoleCreation jobs get queued
2. launchManager.addLaunch(process2.getLaunch()) triggers LaunchConfigurationManager.launchAdded() → removeTerminatedLaunches() → removes process1's launch (it's already terminated, runtime=0)
3. Job manager resumes → ConsoleCreation for process1 runs → checks isRegistered after addConsoles → launch is gone → calls removeLaunch → console removed ✓
4. BUT: sometimes the scheduler runs ConsoleCreation for process2 after its launch was also cleaned up — and the check at the end of run() races with the actual removal

The fix closes two specific windows:

1. Checking isRegistered before creating the console (skips creation entirely if launch already gone)
2. Cancelling pending ConsoleCreation jobs from removeLaunch() (prevents the job from starting at all after removal)

These are logically sound fixes for the identified race, but I cannot provide run counts. That verification would need to happen in a proper CI environment with a display.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• repo.eclipse.org
  • Triggering command: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/21.0.10-7/x64/bin/java /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/21.0.10-7/x64/bin/java --enable-native-access=ALL-UNNAMED -classpath /opt/hostedtoolcache/maven/3.9.12/x64/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/opt/hostedtoolcache/maven/3.9.12/x64/bin/m2.conf -Dmaven.home=/opt/hostedtoolcache/maven/3.9.12/x64 -Dlibrary.jansi.path=/opt/hostedtoolcache/maven/3.9.12/x64/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/eclipse.platform/eclipse.platform org.codehaus.plexus.classworlds.launcher.Launcher verify -pl debug/org.eclipse.debug.tests -Pbuild-individual-bundles -Dtest=ProcessConsoleManagerTests -DfailIfNoTests=false --batch-mode (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[fedejeanne]

@copilot remove the commit with the initial plan, adapt the commit text of the 2nd commit to honor the specification under https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations, rebase on top of origin/master and create a draft PR to merge to the official repository.

[fedejeanne]

@copilot remove the commit with the initial plan, adapt the commit text of the 2nd commit to honor the specification under https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations, rebase on top of origin/master and create a draft PR to merge to the official repository.