fix: issue with first variation having weight of 0 #273
+311
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahad19
commented
Mar 7, 2024
| context: | ||
| country: de | ||
| expectedToBeEnabled: true | ||
| expectedVariation: treatment |
fahad19
commented
Mar 7, 2024
| // range: [0, 0], | ||
| // }, | ||
|
|
||
| { |
There was a problem hiding this comment.
this is failing. the allocation array is mistakenly generated as an empty array.
* main: (48 commits) v1.22.0 feat: show project info in CLI (#304) docs: deprecation (#302) v1.21.0 feat: make test runner fast by default (#301) v1.20.0 feat: allow evaluating in CLI with more verbosity (#300) docs: glossary (#291) v1.19.0 feat: find duplicate segments with authors info (#299) v1.18.1 fix: search features by any case in generated site (#298) v1.18.0 feat: assess traffic distribution via CLI (#297) docs: updates v1.17.0 feat: evaluate features in CLI (#295) v1.16.0 feat: Added export of emitter module (#294) v1.15.0 ...
fahad19
commented
May 25, 2024
| @@ -22,6 +22,10 @@ export function getUpdatedAvailableRangesAfterFilling( | |||
| availableRanges: Range[], | |||
| fill: Percentage, | |||
| ): Range[] { | |||
| if (fill === 0) { | |||
There was a problem hiding this comment.
this was the fix. this. this little if condition.
fahad19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup
0100The issue
The generated datafile does not include variations in
Feature.traffic.allocation.It works though when first variation has weight of
100, and second one0.Workaround
Remove variations with weight of
0, or move it below another variation with a non-0 weight.Where to fix?
Likely in datafile builder: https://github.com/featurevisor/featurevisor/blob/main/packages/core/src/builder/traffic.ts#L63