Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typecheck for the registry tags #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moupriyaroy25
Copy link

Small changes to add type check for registry tags to check if registry_tags is a valid Dict[str, str] parameter.
the registry tags are in a dictionary format like this:

{"description":"this is a test feature"},so valid dictionary parameter.
and if the user does something like this

{"description", "this is a test feature"}, it'll also validate it.

Copy link
Collaborator

@hangfei hangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you add a few tests for this?

Also maybe test dicts that contains non-string objects, like {"apple":[list of things]}

@moupriyaroy25
Copy link
Author

@hangfei Thanks for reviewing. While I am trying to run the tests I am facing some issues during the installation of feathr module on my system. Here is the issue I have mentioned https://stackoverflow.com/questions/72316535/confluent-kafka-install-error-error-legacy-install-failure

@moupriyaroy25
Copy link
Author

@hangfei could you please also elaborate briefly about adding test dicts? Do I need to add any test files for this? I am still so new in this case so adding some links to reference docs might help me figure that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants