Add a retryable mechanism for SWA features when files get deleted #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshkashyap123
added
the
safe to test
jaymo001
reviewed
Mar 29, 2023
| contextDF = if (swaHandler.isDefined) swaHandler.get.join(labelDataDef, factDataDefs.toList) else SlidingWindowJoin.join(labelDataDef, factDataDefs.toList) | ||
| try { | ||
| // THIS IS FOR LOCAL TEST ONLY. It is to induce a spark exception with the root cause of FileNotFoundException. | ||
| if (isRetry && LocalFeatureJoinJob.shouldRetryAddingSWAFeatures) throw new SparkException("file not found", new FileNotFoundException()) |
There was a problem hiding this comment.
Avoid using LocalFeatureJoinJob in non-testing code would be better, e.g. create a class to read as DF, then inject the implementation for local test at runtime.
jaymo001
reviewed
Mar 29, 2023
| @@ -338,6 +338,25 @@ private[offline] class DataFrameFeatureJoiner(logicalPlan: MultiStageJoinPlan, d | |||
| swaObsTime, | |||
| failOnMissingPartition, | |||
| swaHandler) | |||
|
|
|||
| // We will retry the SWA features which could not added because of | |||
| @@ -81,7 +87,9 @@ private[offline] class SlidingWindowAggregationJoiner( | |||
| bloomFilters: Option[Map[Seq[Int], BloomFilter]], | |||
| swaObsTimeOpt: Option[DateTimeInterval], | |||
| failOnMissingPartition: Boolean, | |||
| swaHandler: Option[SWAHandler]): FeatureDataFrame = { | |||
| swaHandler: Option[SWAHandler], | |||
| isRetry: Boolean = true): (FeatureDataFrame, Seq[String]) = { | |||
There was a problem hiding this comment.
isRetry should be shouldRetry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry will happen only once to ensure that the time to fail is not very high.