Fix extern module resolution and module type merging #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ProjectFile, ProjectCompilationResult, and CompiledFile structs - Add ProjectExterns struct with merge functionality and conflict detection - Export ProjectExterns from lib.rs - All structures properly documented with doc comments
- Add ExternCollector struct to extract extern declarations without full semantic analysis - Implement visit methods for extern modules, functions, types, and nested modules - Process js_name attributes correctly for JavaScript interop - Add collect_extern_declarations static method to SemanticVisitor - Add comprehensive unit tests covering all extern patterns: - Empty modules - Functions with signatures - Type declarations - js_name attributes - Function overloading - Project extern merging with conflict detection - Nested module handling This completes Task 1.3 of the extern module resolution fix plan.
- Add with_project_context constructor for two-pass compilation - Register all extern module functions in functions HashMap for proper lookup - Update function index for performance optimization - Merge extern types into type environment - Add comprehensive documentation explaining the two-pass strategy - Add unit test to verify constructor functionality This completes Task 1.4 and finishes Phase 1 of the extern module resolution fix.
…erging - Add two-pass compilation with ProjectExterns for cross-file extern visibility - Fix ExternCollector type alias resolution (e.g., PathLike = any) - Fix missing merge_module_types call in analyze_local_module - Enable enum variant constructors from imported modules - All 623 tests now pass This allows extern declarations in one file to be visible when importing from modules in other files, fixing the fs-example build issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
1. Two-Pass Compilation with ProjectExterns
ProjectExternsstruct to collect and share extern declarations across filesExternCollectorvisitor to extract extern declarations in first passtranspile_projectto collect externs before semantic analysisSemanticVisitorto accept optional project context2. Type Alias Resolution Fix
ExternCollectorto properly resolve type aliases likePathLike = anyresolve_type_stringmethod to check extern_types before creating types3. Module Type Merging Fix
merge_module_typesinanalyze_local_moduleOperation::Add(5)) from imported modulesTest Results
The
fs-examplenow builds and runs successfully, demonstrating that extern declarations in one file are properly visible when importing from modules in other files.Fixes
Resolves the issue where extern module declarations were not visible across files in multi-file projects.