Remove global import of 'DOM' type definitions. This is polluting customers environments by polluting the global type namespace. #323
+27
−5,754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleve-fauna
force-pushed
the
main_fixBuildIssues
branch
from
e2e1e37 to
ae99e92
Compare
…e the global type namespace.
cleve-fauna
force-pushed
the
main_fixBuildIssues
branch
from
ae99e92 to
dcf28de
Compare
ptpaterson
previously approved these changes
Feb 5, 2025
| rules: { | ||
| "@typescript-eslint/no-explicit-any": ["off"], | ||
| "tsdoc/syntax": "error", | ||
| "@typescript-eslint/triple-slash-reference": [ | ||
| "error", | ||
| { lib: "never", path: "never", types: "never" }, |
ecooper
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are exporting the entire DOM lib as a library. Don't do that.
A recent commit added package-lock.json. We don't need that. Remove it.
Motivation and context
This breaks customer build environments as it pollutes the global type namespace.
How was the change tested?
I built with and without the changes here. You can see in the build the Triple-Slash-Directive used to be present but is no longer. Furthermore the linter I added throws in the original, but succeeds now.
Screenshots (if appropriate):
Before:
After:
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Out of Scope
The linter needs attention in general. It needs to move onto the latest version of eslint. Will work on that separately.