Skip to content

Support cloning up to 7 times #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented May 14, 2025

Description

@makoeppel from ETH needs cloning to support up to 6 actually 7 clones for the Inception model for some project with PSI people.

Type of change

  • New feature (non-breaking change which adds functionality)

Tests

Extended the test in test_stream_clone.py to test all new cases.

Checklist

  • I have checked all the items in the checklist

@vloncar vloncar changed the title Support cloning up to 6 times Support cloning up to 7 times May 15, 2025
@calad0i
Copy link
Contributor

calad0i commented May 15, 2025

Should we just go with codegen at this point 😂...?

@vloncar
Copy link
Contributor Author

vloncar commented May 15, 2025

Maybe if we actually had code-gen and not just a string template manipulation... 😉

Copy link
Contributor

@calad0i calad0i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@calad0i calad0i merged commit 5e45cc2 into fastmachinelearning:main May 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants