Reject core cache body ranges where the end precedes the start #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
cceckman-at-fastly
force-pushed
the
cceckman/invalid-range
branch
from
c85a09c to
529370e
Compare
cceckman-at-fastly
added a commit
that referenced
this pull request
Jun 11, 2025
Fixes and tweaks for the get-vcpu-ms test, which was failing in CI for the unrelated PR #1182. - **Use more verbose failure in get-vcpu-ms test**, so we know which assertion failed - **Formatting fixes**, because I don't know JS style - **Fix spacing around truthy debug message**, because it put the space in the wrong place - **Weaken assertion around vCPU startup time: >=0, not >0**, because apparently the runtime's startup is so good now that this assertion fails
These are rejected in Go as of fastly/compute-sdk-go#165, and in Rust as of PR 5097 in that repository. This is a guest (SDK/runtime) change rather than a host change so as not to break users that may accidentallly rely on this "feature"; hopefully their next SDK upgrade will highlight the issue.
cceckman-at-fastly
force-pushed
the
cceckman/invalid-range
branch
from
529370e to
ab2c1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are rejected in Go as of fastly/compute-sdk-go#165, and in Rust as of PR 5097 in that repository.
This is a guest (SDK/runtime) change rather than a host change so as not to break users that may accidentally rely on this "feature"; hopefully their next SDK upgrade will highlight the issue.