Enable relaxed-simd-deterministic for Viceroy. #539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wasm spec defines several relaxed SIMD instructions, which are permitted to have nondeterministic results, in order to accommodate differences between hardware CPU architectures. However, rather than being fully nondeterministic, it requires them to be deterministic within a run of a program, so that programs can assume that whatever behavior they see the first time they use a relaxed SIMD instruction will continue to be the behavior for the rest of the run of the program.
Fastly's Compute platform makes use of snapshotting using wizer to optimize program startup times. This involves running the program initialization on one machine, snapshotting the program, and then resuming the program on another. To ensure that the relaxed SIMD instructions don't change behavior across the snapshot and resume, enable the deterministic lowerings.