Partial implementation of cache API #454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CollectingBody` reads from a `Body` and: - Stores the data and trailers written, for future delivery in cache lookups - Offers a `read() -> Body` endpoint. The read can proceed concurrently with writes, or after the write has completed.
cceckman-at-fastly
force-pushed
the
cceckman/cache-nontransact
branch
from
5ca4bd5 to
53bac42
Compare
drbrain
reviewed
Mar 11, 2025
| } | ||
|
|
||
| proptest! { | ||
| #[test] |
There was a problem hiding this comment.
Is #[tokio::test] not usable inside proptest!?
There was a problem hiding this comment.
Unfortunately, yeah; both of them are doing Things to the signatures of the relevant functions, and they aren't orthogonal. Added a comment.
cceckman-at-fastly
force-pushed
the
cceckman/cache-nontransact
branch
from
53bac42 to
b9bae09
Compare
Missed the "skip already read chunks" step.
Implement the non-transactional API with many limitations: - No streaming bodies (which also makes the test brittle) - No options processing
Some of the core cache API hostcalls are incomplete; namely, `insert` and `lookup` don't respect the "option" arguments. We don't want to enable access to those APIs in a way that will misbehave (e.g. ignoring arguments). Guard the use (and testing) of the incomplete APIs behind an environment variable, ENABLE_EXPERIMENTAL_CACHE_API. When present, we enable the API and run the tests.
This covers the stream-through-cache case. Include a note on why we can't exercise "input error from stream" in an integration test.
cceckman-at-fastly
force-pushed
the
cceckman/cache-nontransact
branch
from
b9bae09 to
8d0cd45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum possible implementation. Limitations:
insertandlookup; no transactionsSince the insert/lookup options are not supported, the
insertandlookupmethods still return unavailable by default. They are enabled at runtime byENABLE_EXPERIMENTAL_CACHE_API=1in the environment.