Add CollectingBody for cache use cases #452
Open
+371
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cceckman-at-fastly
requested review from
a team,
dcaba and
aturon
and removed request for
a team
`CollectingBody` reads from a `Body` and: - Stores the data and trailers written, for future delivery in cache lookups - Offers a `read() -> Body` endpoint. The read can proceed concurrently with writes, or after the write has completed.
cceckman-at-fastly
force-pushed
the
cceckman/collecting-body
branch
from
67d06cd to
7f2e452
Compare
drbrain
reviewed
Mar 11, 2025
drbrain
reviewed
Mar 11, 2025
drbrain
reviewed
Mar 11, 2025
drbrain
reviewed
Mar 11, 2025
lib/src/collecting_body.rs
Outdated
| return; | ||
| } | ||
|
|
||
| // OK, we have some data. Forward it. In order, |
There was a problem hiding this comment.
The state pattern described above also means these comments become a match
There was a problem hiding this comment.
Kinda?
We can't hold the Ref<CollectingBodyInner> across an .await point (i.e. a send), so we have to match on the inside then do the work. (We don't want to block the send on a receive happening - one way to deadlock.) So it's still a matter of copying out the work and then matching on the length/Someness.
Missed the "skip already read chunks" step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectingBodyreads from aBodyand:lookups
read() -> Bodyendpoint. The read can proceed concurrentlywith writes, or after the write has completed.