[supply] Fix halted status change handling #22004
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21431
We can't suspend (halt) the distribution of track on Google Play. As my comment, status updates are ignored or requested with incorrect parameters.
Fastfile
Description
Added halting handling if track_remote_release_status equals
halted
.Supply::Uploader#perform_upload behaves as follows, therefore halted processing was skipped.
I tried to fix something in the above steps, but it should require unnecessary parameters or unnatural steps (and it will make conditional branches more complex).
When halting the track, there should be no binary change and no change to track_promote_to and rollout, so I think it's better to handle additional logic rather than modifying existing steps.
fastlane/supply/lib/supply/uploader.rb
Lines 15 to 37 in fbad7d8
It may be better to update documents too if merged.
Google Play Publisher API:
https://developers.google.com/android-publisher/tracks
Testing Steps
For alpha track: