[pilot] Fix ASC API error when reject_build_waiting_for_review: true

[AliSoftware]

Fixes #18408

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.
• I've added or updated relevant unit tests.

Motivation and Context

The ASC API to delete TestFlight pending builds doesn't exist, so when fastlane's pilot is trying to reject_build_waiting_for_review, we get this error:

The resource 'betaAppReviewSubmissions' does not allow 'DELETE'. Allowed operations are: GET_COLLECTION, GET_INSTANCE, CREATE

Description

Applying the fix from #18408 (comment) to delete pending submissions properly — kudos to @nid90 for the code of the fix.

Testing Steps

I've just tested the fix with one of our apps which has a TestFlight build still in "Waiting for Review" state.

• When we tried to submit a new build earlier today, the lane failed with the above error about DELETE not being allowed.
• After trying to submit another new build while pointing my Gemfile to this branch of the fastlane repo, this time it passed with the following logs in our CI:

[09:37:53 -0700]: Another build is already in review. Going to remove that build and submit the new one.
[09:37:53 -0700]: Canceling beta app review submission for build: 34.5 - 345001
[09:37:55 -0700]: Canceled beta app review submission for previous build: 34.5 - 345001
[09:37:55 -0700]: Distributing new build to testers: 34.5 - 345003

and the previous build 345001 was properly marked as "Expired" in TestFlight after that:

[mokagio]

Nitpick: Not sure if the scope is the same or if the visibility between spaceship and pilot would allow it, but if it is, would you consider DRYing these "magic strings" in favor of

fastlane/spaceship/lib/spaceship/connect_api/models/app_info.rb

Lines 44 to 55 in df12128

	module State
	ACCEPTED = "ACCEPTED"
	DEVELOPER_REJECTED = "DEVELOPER_REJECTED"
	IN_REVIEW = "IN_REVIEW"
	PENDING_RELEASE = "PENDING_RELEASE"
	PREPARE_FOR_SUBMISSION = "PREPARE_FOR_SUBMISSION"
	READY_FOR_DISTRIBUTION = "READY_FOR_DISTRIBUTION"
	READY_FOR_REVIEW = "READY_FOR_REVIEW"
	REJECTED = "REJECTED"
	REPLACED_WITH_NEW_INFO = "REPLACED_WITH_NEW_INFO"
	WAITING_FOR_REVIEW = "WAITING_FOR_REVIEW"
	end

[mokagio]

Not sure if the scope is the same

After looking at the connect_api/models folder, I don't think the scope is the same. It's likely that the words used by the API would not change, but it would not be appropriate to use one for the other.

[AliSoftware]

It's likely that the words used by the API would not change

@mokagio You've clearly never worked with Apple's ASC API 😅😁 (they've changed the API without warning—nor updating their doc—at multiple occasions in the past sadly, requiring us to update fastlane in a hurry sometimes to account for the sudden change 😑)

[fabiendem]

Can we keep the DRY refactors for another PR? It slows down the adoption of fixes.
We can limit the scope of this PR to the actual fix.
Would love to see this change in, it's been a problem for ages.