Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google credentials term from Developer Account ID to Google Cloud Project ID #1239

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

blueelvis
Copy link
Contributor

@blueelvis blueelvis commented Feb 28, 2024

Updated typo for the Google Cloud Project ID instead of Developer Account ID.

Resolves #1238

Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this isn't the only occurrence:

docs/includes/google-credentials.md Outdated Show resolved Hide resolved
Fixed as per review comments
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 thanks for this!

@rogerluan rogerluan changed the title Update google-credentials.md Update Google credentials term from Developer Account ID to Google Cloud Project ID Jun 4, 2024
@rogerluan rogerluan merged commit 54969f4 into fastlane:master Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fastlane Android Setup page needs to be updated
3 participants