[WIP] Add support for dropdown to select the iTC testing group #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I wasn't able to test this, as I didn't find a way to create a second group.
This PR adds a functionality to provide a white list of tester groups a user should be able to select from. This is useful in case you have multiple groups, for example
Release Candidates
andNightly
and want each user to choose which program they want to be part of.The dropdown uses a white-list approach, as many dev teams probably have groups they want to use internally only (or maybe invite-only). This PR also makes sure that the user didn't manually add a new item to the request and try to add themselves by guessing names.
Also, the dropdown is automatically hidden if no white list is provided, or if there is only group provided. The group names are separated by the
;
character.Idea and lobbying by @steipete, :club_mate: works every single time :)
Missing pieces:
app.json