Release: v2.57.0 #2134
Release: v2.57.0 #2134
Conversation
There was a problem hiding this comment.
Pull request overview
This release (v2.57.0) introduces Windows 7 compatibility management, xterm 256 color support, and various platform-specific improvements. Key changes include refactoring header include paths from util/ to common/ throughout the codebase, adding support for COSMIC DE and niri WM detection on Linux, and implementing secure boot detection on macOS.
Reviewed changes
Copilot reviewed 263 out of 446 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Documents new features, bugfixes, and deprecation of Windows 7 support |
| .github/workflows/ci.yml | Updates CI configuration to build separate Windows 7-compatible binaries and OpenBSD package versions |
| presets/examples/31.jsonc | Adds new Evangelion-themed preset configuration with xterm 256 colors |
| doc/json_schema.json | Fixes schema definitions for keyboard and mouse module format references |
| src/common/* | Refactors include paths and implements new networking/time functions |
| src/detection/* | Updates include paths from util/ to common/ across all detection modules |
* Logo (Builtin): adds Xinux logo * Fix formatting in xinux.txt ASCII art --------- Co-authored-by: Carter Li <[email protected]>
…NSI LIGHT_RED (#2138) Co-authored-by: ctb248 <[email protected]>
1. updates JSON schema 2. removes unused fields 3. runs tests in CI
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 264 out of 451 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/common/font.h:1
- The logic unconditionally appends 'pt' when the size doesn't already end with 'pt' or 'px'. Consider checking if the size is numeric before appending a unit, as non-numeric sizes might not need units.
#pragma once
| if (contentLength > 0 && buffer->length != contentLength + headerEnd + 4) { | ||
| FF_DEBUG("Received content length mismatches: %u != %u", buffer->length, contentLength + headerEnd + 4); | ||
| return "Content length mismatch"; | ||
| } |
There was a problem hiding this comment.
The constant '4' appears to represent the length of '\r\n\r\n'. Consider defining it as a named constant to improve code clarity.
| #if __aarch64__ | ||
| if (detectFromIokit(result) == NULL) | ||
| return NULL; | ||
| #endif |
There was a problem hiding this comment.
The conditional compilation for aarch64 should include a comment explaining why IOKit detection is only attempted on ARM64 systems, as this platform-specific behavior may not be obvious to future maintainers.
No description provided.