Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization to building OPAL Class Hierarchies #490

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mir-am
Copy link
Contributor

@mir-am mir-am commented Sep 15, 2022

Description

This is a small PR that makes the following changes:

  • creates a new method asURIHierarchyParallel() to create Fasten URIs in parallel. The speed up is 2 times, especially for large graphs.
  • Make createGraphWithExternalCHA faster by using parallel stream.

Overall, the speed up is up to 2-3x times.

Motivation and context

When creating (very large) partial call graphs, building FURI hierarchies can be very time-consuming if it's done in single-thread mode.

Testing

Unit tests pass for the OPAL plugin.

@mir-am mir-am added the enhancement New feature or request label Sep 15, 2022
@mir-am mir-am self-assigned this Sep 15, 2022
@mir-am
Copy link
Contributor Author

mir-am commented Sep 21, 2022

@ashkboos, thanks a lot, Mehdi, for the contribution and help with the optimization of OPAL data structures.

@mir-am
Copy link
Contributor Author

mir-am commented Oct 1, 2022

@ashkboos
What is the verdict on this PR? Shall we merge it into develop?

@ashkboos
Copy link
Contributor

ashkboos commented Oct 1, 2022

@ashkboos What is the verdict on this PR? Shall we merge it into develop?

To me it's fine. Unless Sebastian also wants to take a look.

@mir-am mir-am requested a review from proksch October 1, 2022 12:38
@mir-am
Copy link
Contributor Author

mir-am commented Oct 1, 2022

I would like to request a review from @proksch as he recently refactored OPALPartialCallGraphConstructor.

@MagielBruntink
Copy link
Member

What is the status of this PR? Do we still want to merge it?

@mir-am
Copy link
Contributor Author

mir-am commented Feb 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants