fix(event)!: use typed-path for filesystem paths #26
Conversation
poiana
added
release-note-none
dco-signoff: yes
kind/bug
|
/hold (there might be some more low-hanging Windows fruit) |
gnosek
force-pushed
the
typed-path
branch
2 times, most recently
from
358e119 to
e626b5e
Compare
|
This PR now makes the tests actually pass on Windows (some win11 VM I had lying around) |
|
LGTM label has been added. Git tree hash: cb8bfec29e30f7af3ca050e845451ae258112552
|
This should make them work consistently on Windows, where e.g. PT_FSPATH still describes a Unix-style path. Signed-off-by: Grzegorz Nosek <[email protected]>
They're there because of some system header and they're not used at all in the API. Still, `long` inside imaxdiv_t has a different size on Windows (MSVC) vs Linux and causes a generated test to (harmlessly) fail. Signed-off-by: Grzegorz Nosek <[email protected]>
There's only one occurrence, that's never actually shared across the API boundary (and never really used by the Rust bindings), so any type would work fine. Still, `long` has a different size on Windows, so this (harmlessly) breaks two tests. Signed-off-by: Grzegorz Nosek <[email protected]>
When testing the string representation of SystemTime values, rather than setting the time zone to UTC (which doesn't work on Windows), generate the right string representations in whatever the local time zone is and compare the values from the plugin against those. Signed-off-by: Grzegorz Nosek <[email protected]>
Signed-off-by: Grzegorz Nosek <[email protected]>
|
LGTM label has been added. Git tree hash: f94fb07ea243597be99fb990924c3e1f07bbf0fc
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, gnosek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This should make them work consistently on Windows, where e.g. PT_FSPATH still describes a Unix-style path.
Also, this lets the SDK build on Windows in the first place.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area event
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: