-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(libscap): use scap_errprintf
for scap errors handling
#2286
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please double check driver/API_VERSION file. See versioning. /hold |
/milestone 0.21.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2286 +/- ##
=======================================
Coverage 75.32% 75.32%
=======================================
Files 280 280
Lines 34556 34556
Branches 5902 5902
=======================================
Hits 26031 26031
Misses 8525 8525
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4bbc1ad
to
0e1dd26
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Signed-off-by: Leonardo Di Giovanna <[email protected]>
0e1dd26
to
174aafa
Compare
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libscap-engine-bpf
/area libscap-engine-gvisor
/area libscap-engine-kmod
/area libscap-engine-modern-bpf
/area libscap-engine-nodriver
/area libscap-engine-noop
/area libscap-engine-source-plugin
/area libscap-engine-savefile
/area libscap
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR replaces all custom scap errors handing with the usage of
scap_errprintf
macro.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: