Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): add support for 16K kernel page to jemalloc #3490

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Darkness4
Copy link
Contributor

@Darkness4 Darkness4 commented Feb 10, 2025

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This PR adds support for 16k-sized kernel page for jemalloc, resolving an issue.

Which issue(s) this PR fixes:

Fixes #3476

Does this PR introduce a user-facing change?:

fix(cmake): add support for 16K kernel page to jemalloc

/cc FedeDP

@poiana
Copy link
Contributor

poiana commented Feb 10, 2025

Welcome @Darkness4! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Feb 10, 2025
@Darkness4 Darkness4 force-pushed the fix/jemalloc-support-16k branch from 69c68ed to b6d1821 Compare February 10, 2025 10:06
@Darkness4 Darkness4 force-pushed the fix/jemalloc-support-16k branch from b6d1821 to 5724158 Compare February 10, 2025 10:07
@Darkness4 Darkness4 marked this pull request as ready for review February 10, 2025 10:09
@FedeDP
Copy link
Contributor

FedeDP commented Feb 10, 2025

/milestone 0.41.0

Thanks for this PR!

@poiana poiana added this to the 0.41.0 milestone Feb 10, 2025
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Darkness4, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 10, 2025

LGTM label has been added.

Git tree hash: b2e2875e32f61643a8b60b0ac463c306f5fd0708

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana poiana merged commit c4081d7 into falcosecurity:master Feb 11, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FATAL]: <jemalloc>: Unsupported system page size
4 participants