-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(falco/app): move actions not using config before load_config
#3483
base: master
Are you sure you want to change the base?
Conversation
/hold |
b4b7924
to
e6985ca
Compare
/unhold |
LGTM label has been added. Git tree hash: 360ef8fd74500a4b97fa131526c9c6aa5dabcf08
|
Move actions not requiring config to be loaded before `load_config` action. This avoid resource waste. Notably, `print_help` is promoted as first execution action. Moreover, set actions lists to constant expressions. Signed-off-by: Leonardo Di Giovanna <[email protected]>
e6985ca
to
c5db6c5
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: 55366616085074c68715e2fc1341ed34d41b6ee0
|
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR moves, before the
load_config
action, all actions not requiring the config to be loaded. This avoid resources waste. Notably, it promotesprint_help
as first executed action. Moreover, it sets actions lists to constant expressions.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: