Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(falco/app): move actions not using config before load_config #3483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Feb 4, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This PR moves, before the load_config action, all actions not requiring the config to be loaded. This avoid resources waste. Notably, it promotes print_help as first executed action. Moreover, it sets actions lists to constant expressions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ekoops
Copy link
Contributor Author

ekoops commented Feb 5, 2025

/hold

@ekoops ekoops force-pushed the ekoops/anticipate-app-actions branch from b4b7924 to e6985ca Compare February 5, 2025 10:38
@ekoops
Copy link
Contributor Author

ekoops commented Feb 5, 2025

/unhold

sgaist
sgaist previously approved these changes Feb 5, 2025
@poiana
Copy link
Contributor

poiana commented Feb 5, 2025

LGTM label has been added.

Git tree hash: 360ef8fd74500a4b97fa131526c9c6aa5dabcf08

Move actions not requiring config to be loaded before `load_config`
action. This avoid resource waste. Notably, `print_help` is
promoted as first execution action. Moreover, set actions lists to
constant expressions.

Signed-off-by: Leonardo Di Giovanna <[email protected]>
@ekoops ekoops force-pushed the ekoops/anticipate-app-actions branch from e6985ca to c5db6c5 Compare February 6, 2025 14:47
@poiana poiana removed the lgtm label Feb 6, 2025
@poiana poiana requested a review from sgaist February 6, 2025 14:47
@poiana
Copy link
Contributor

poiana commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ekoops
Once this PR has been reviewed and has the lgtm label, please ask for approval from sgaist. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana poiana added the lgtm label Feb 6, 2025
@poiana
Copy link
Contributor

poiana commented Feb 6, 2025

LGTM label has been added.

Git tree hash: 55366616085074c68715e2fc1341ed34d41b6ee0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants