Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-config.md #1445

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update grpc-config.md #1445

merged 1 commit into from
Feb 4, 2025

Conversation

arpit-jaswani
Copy link
Contributor

@arpit-jaswani arpit-jaswani commented Feb 4, 2025

Fixed command arguments order to make it working. Putting argument after size was not in correct order and causing Extra arguments given. error.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
Fixes the argument order to generate CA and Server certificate key. Argument -passout is not in correct order for these two key generation commands.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Fixed command arguments order to make it working. Putting argument after size was not in correct order and causing *Extra arguments given.* error.

Signed-off-by: Arpit Jaswani <[email protected]>
@poiana
Copy link

poiana commented Feb 4, 2025

Welcome @arpit-jaswani! It looks like this is your first PR to falcosecurity/falco-website 🎉

@poiana poiana requested review from mstemm and vjjmiras February 4, 2025 19:27
@poiana poiana added the size/XS label Feb 4, 2025
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@poiana poiana added the lgtm label Feb 4, 2025
@poiana
Copy link

poiana commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arpit-jaswani, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Feb 4, 2025

LGTM label has been added.

Git tree hash: 5f5fa9deac5bfd55cbbb1cb034674f4355aa0ba0

@poiana poiana added the approved label Feb 4, 2025
@poiana poiana merged commit 817be3b into falcosecurity:master Feb 4, 2025
6 of 7 checks passed
@arpit-jaswani arpit-jaswani deleted the patch-1 branch February 4, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants