Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website restructuring, the "concepts" section [2/N] #1421

Merged
merged 20 commits into from
Jan 13, 2025

Conversation

leogr
Copy link
Member

@leogr leogr commented Dec 13, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:

See #1365

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR groups relevant sections under the new concept's menu item 👇
image

Several adaptations, improvements, and cleanups have also been introduced on top to achieve a minimum of consistency.

However, the result is far from being ideal. A massive second pass will be required later (I haven't included all the fixes in this PR because it's already huge).

Please consider this is an intermediate state (still consistent) when reviewing this PR. Thanks 🙏

@leogr leogr force-pushed the refactor/concepts-section branch from 524de9e to 102766b Compare December 20, 2024 10:45
@leogr leogr changed the title wip: website restructuring, the "concepts" section [2/N] website restructuring, the "concepts" section [2/N] Dec 20, 2024
leogr and others added 2 commits January 13, 2025 12:20
Co-authored-by: Luca Guerra <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Luca Guerra <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
@leogr leogr requested a review from LucaGuerra January 13, 2025 11:42
content/en/docs/concepts/event-sources/_index.md Outdated Show resolved Hide resolved
content/en/docs/concepts/event-sources/_index.md Outdated Show resolved Hide resolved
leogr and others added 4 commits January 13, 2025 15:19
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
@leogr leogr requested a review from Issif January 13, 2025 14:21
@Issif
Copy link
Member

Issif commented Jan 13, 2025

/lgtm

@poiana poiana added the lgtm label Jan 13, 2025
@poiana
Copy link

poiana commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cdedece into master Jan 13, 2025
6 checks passed
@poiana poiana deleted the refactor/concepts-section branch January 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants