-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website restructuring, the "concepts" section [2/N] #1421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8578c75
to
4bf1987
Compare
fa0ca89
to
622259c
Compare
b6a3f30
to
c25eeb4
Compare
d1d09a7
to
8a8dd5e
Compare
cc446f8
to
524de9e
Compare
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
…ource" sections Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
524de9e
to
102766b
Compare
LucaGuerra
reviewed
Jan 8, 2025
LucaGuerra
reviewed
Jan 8, 2025
Co-authored-by: Luca Guerra <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Luca Guerra <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
Issif
reviewed
Jan 13, 2025
Issif
reviewed
Jan 13, 2025
Issif
requested changes
Jan 13, 2025
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
Co-authored-by: Thomas Labarussias <[email protected]> Signed-off-by: Leonardo Grasso <[email protected]>
/lgtm |
Issif
approved these changes
Jan 13, 2025
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
See #1365
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR groups relevant sections under the new concept's menu item 👇
![image](https://private-user-images.githubusercontent.com/3390997/396559539-9d40b888-57ae-4781-9cf5-14145b7a25aa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MzUzNDYsIm5iZiI6MTczOTUzNTA0NiwicGF0aCI6Ii8zMzkwOTk3LzM5NjU1OTUzOS05ZDQwYjg4OC01N2FlLTQ3ODEtOWNmNS0xNDE0NWI3YTI1YWEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTIxMDQ2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWVjOTIzZTExN2ZlN2VjNGE0OTQ2NjQ1NGFlMDdhOTVlMGM2NDM5YjdkZTk2YTExMjM2MDdlNDQ1ZGI3OGU3YyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.D0pd24u5wYttLsMiZeg6Dw08LSpAJOX-fnMPy3-UDaU)
Several adaptations, improvements, and cleanups have also been introduced on top to achieve a minimum of consistency.
However, the result is far from being ideal. A massive second pass will be required later (I haven't included all the fixes in this PR because it's already huge).
Please consider this is an intermediate state (still consistent) when reviewing this PR. Thanks 🙏